Skip to content

fix uncapped width for datetime charts #7041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 3, 2025
Merged

fix uncapped width for datetime charts #7041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fe7280
fix uncapped width for datetime charts
Light2Dark Nov 3, 2025
d117648
update snapshot
Light2Dark Nov 3, 2025
8d972c6
fix dates timezone test, edt or est
Light2Dark Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
372 changes: 2 additions & 370 deletions frontend/src/components/data-table/__tests__/__snapshots__/chart-spec-model.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ exports[`ColumnChartSpecModel > should handle datetime bin values 1`] = `
},
],
},
"height": 100,
"height": 30,
"layer": [
{
"encoding": {
Expand Down Expand Up @@ -497,6 +497,7 @@ exports[`ColumnChartSpecModel > should handle datetime bin values 1`] = `
},
},
],
"width": 75,
}
`;

Expand Down Expand Up @@ -629,375 +630,6 @@ exports[`ColumnChartSpecModel > should handle string value counts 1`] = `
}
`;

exports[`ColumnChartSpecModel > snapshot > array 1`] = `
{
"background": "transparent",
"config": {
"axis": {
"domain": false,
},
"view": {
"stroke": "transparent",
},
},
"data": {
"values": [
"a",
"b",
"c",
],
},
"height": 100,
"layer": [
{
"encoding": {
"x": {
"bin": true,
"field": "a",
"type": "quantitative",
},
"y": {
"aggregate": "count",
"axis": null,
"type": "quantitative",
},
},
"mark": {
"color": "#027864",
"type": "bar",
},
},
{
"encoding": {
"tooltip": [
{
"bin": true,
"field": "a",
"format": ".2f",
"title": "a",
"type": "quantitative",
},
{
"aggregate": "count",
"format": ",d",
"title": "Count",
"type": "quantitative",
},
],
"x": {
"axis": {
"labelExpr": "(datum.value >= 10000 || datum.value <= -10000) ? format(datum.value, '.2e') : format(datum.value, '.2~f')",
"labelFontSize": 8.5,
"labelOpacity": 0.5,
"title": null,
},
"bin": true,
"field": "a",
"type": "quantitative",
},
"y": {
"aggregate": "max",
"axis": null,
"type": "quantitative",
},
},
"mark": {
"opacity": 0,
"type": "bar",
},
},
],
}
`;

exports[`ColumnChartSpecModel > snapshot > csv data 1`] = `
{
"background": "transparent",
"config": {
"axis": {
"domain": false,
},
"view": {
"stroke": "transparent",
},
},
"data": {
"values": [
{
"a": 1,
"b": 2,
"c": 3,
},
{
"a": 4,
"b": 5,
"c": 6,
},
],
},
"height": 100,
"layer": [
{
"encoding": {
"x": {
"bin": true,
"field": "a",
"type": "quantitative",
},
"y": {
"aggregate": "count",
"axis": null,
"type": "quantitative",
},
},
"mark": {
"color": "#027864",
"type": "bar",
},
},
{
"encoding": {
"tooltip": [
{
"bin": true,
"field": "a",
"format": ".2f",
"title": "a",
"type": "quantitative",
},
{
"aggregate": "count",
"format": ",d",
"title": "Count",
"type": "quantitative",
},
],
"x": {
"axis": {
"labelExpr": "(datum.value >= 10000 || datum.value <= -10000) ? format(datum.value, '.2e') : format(datum.value, '.2~f')",
"labelFontSize": 8.5,
"labelOpacity": 0.5,
"title": null,
},
"bin": true,
"field": "a",
"type": "quantitative",
},
"y": {
"aggregate": "max",
"axis": null,
"type": "quantitative",
},
},
"mark": {
"opacity": 0,
"type": "bar",
},
},
],
}
`;

exports[`ColumnChartSpecModel > snapshot > csv string 1`] = `
{
"background": "transparent",
"config": {
"axis": {
"domain": false,
},
"view": {
"stroke": "transparent",
},
},
"data": {
"values": [
{
"a": 1,
"b": 2,
"c": 3,
},
{
"a": 4,
"b": 5,
"c": 6,
},
],
},
"height": 100,
"layer": [
{
"encoding": {
"x": {
"bin": true,
"field": "a",
"type": "quantitative",
},
"y": {
"aggregate": "count",
"axis": null,
"type": "quantitative",
},
},
"mark": {
"color": "#027864",
"type": "bar",
},
},
{
"encoding": {
"tooltip": [
{
"bin": true,
"field": "a",
"format": ".2f",
"title": "a",
"type": "quantitative",
},
{
"aggregate": "count",
"format": ",d",
"title": "Count",
"type": "quantitative",
},
],
"x": {
"axis": {
"labelExpr": "(datum.value >= 10000 || datum.value <= -10000) ? format(datum.value, '.2e') : format(datum.value, '.2~f')",
"labelFontSize": 8.5,
"labelOpacity": 0.5,
"title": null,
},
"bin": true,
"field": "a",
"type": "quantitative",
},
"y": {
"aggregate": "max",
"axis": null,
"type": "quantitative",
},
},
"mark": {
"opacity": 0,
"type": "bar",
},
},
],
}
`;

exports[`ColumnChartSpecModel > snapshot > url data 1`] = `
{
"background": "transparent",
"config": {
"axis": {
"domain": false,
},
"view": {
"stroke": "transparent",
},
},
"data": {
"values": [],
},
"height": 100,
"layer": [
{
"encoding": {
"color": {
"condition": {
"test": "datum["bin_maxbins_10_date_range"] === "null"",
"value": "#cc4e00",
},
"value": "#027864",
},
"x": {
"axis": null,
"bin": true,
"field": "date",
"scale": {
"align": 0,
"paddingInner": 0,
"paddingOuter": {
"expr": "length(data('data_0')) == 2 ? 1 : length(data('data_0')) == 3 ? 0.5 : length(data('data_0')) == 4 ? 0 : 0",
},
},
"type": "temporal",
},
"y": {
"aggregate": "count",
"axis": null,
"type": "quantitative",
},
},
"mark": {
"color": "#027864",
"type": "bar",
},
},
{
"encoding": {
"color": {
"condition": {
"test": "datum["bin_maxbins_10_date_range"] === "null"",
"value": "#cc4e00",
},
"value": "#027864",
},
"tooltip": [
{
"bin": {
"binned": true,
},
"field": "bin_maxbins_10_date",
"format": "%Y-%m-%d",
"title": "date (start)",
"type": "temporal",
},
{
"bin": {
"binned": true,
},
"field": "bin_maxbins_10_date_end",
"format": "%Y-%m-%d",
"title": "date (end)",
"type": "temporal",
},
{
"aggregate": "count",
"format": ",d",
"title": "Count",
"type": "quantitative",
},
],
"x": {
"axis": null,
"bin": true,
"field": "date",
"scale": {
"align": 0,
"paddingInner": 0,
"paddingOuter": {
"expr": "length(data('data_0')) == 2 ? 1 : length(data('data_0')) == 3 ? 0.5 : length(data('data_0')) == 4 ? 0 : 0",
},
},
"type": "temporal",
},
"y": {
"aggregate": "max",
"axis": null,
"type": "quantitative",
},
},
"mark": {
"opacity": 0,
"type": "bar",
},
},
],
}
`;

exports[`ColumnChartSpecModel > snapshot with legacy data spec > array 1`] = `
{
"background": "transparent",
Expand Down
Loading
Loading