Skip to content

disable sql linter #7022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

disable sql linter #7022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions frontend/src/components/app-config/data-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import type { ChangeEvent } from "react";
import type { FieldPath, UseFormReturn } from "react-hook-form";
import { Checkbox } from "@/components/ui/checkbox";
import {
FormControl,
FormDescription,
Expand Down Expand Up @@ -213,7 +212,8 @@ export const DataForm = ({
{renderDiscoveryForm("datasources.auto_discover_columns", "Columns")}
</div>

<FormField
{/* TODO: Issue with frontend being stuck */}
{/* <FormField
control={form.control}
name="diagnostics.sql_linter"
render={({ field }) => (
Expand All @@ -238,7 +238,7 @@ export const DataForm = ({
</FormDescription>
</div>
)}
/>
/> */}

<FormField
control={form.control}
Expand Down
3 changes: 2 additions & 1 deletion frontend/src/core/codemirror/language/languages/sql/sql.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,8 @@ export class SQLLanguageAdapter
}),
];

const sqlLinterEnabled = lspConfig?.diagnostics?.sql_linter ?? false;
// TODO: Issue with frontend being stuck
const sqlLinterEnabled = false;

if (sqlLinterEnabled) {
const theme = store.get(resolvedThemeAtom);
Expand Down
Loading