Skip to content

test notebook status #7013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

test notebook status #7013

wants to merge 6 commits into from

Conversation

@mscolnick
Copy link
Contributor

@mscolnick mscolnick commented Oct 30, 2025 •
edited
Loading

@vercel
Copy link

vercel bot commented Oct 30, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Oct 30, 2025 8:03pm

@mscolnick
Copy link
Contributor Author

mscolnick commented Oct 30, 2025

there is a mismatch from what looks like the status and the status the code is giving

FAILED tests/_ast/test_load.py::TestGetStatus::test_get_status[test_get_alias_import-valid] - AssertionError: assert 'has_errors' == 'valid'
FAILED tests/_ast/test_load.py::TestGetStatus::test_get_status[test_get_codes_non_marimo_python_script-valid] - AssertionError: assert 'invalid' == 'valid'
FAILED tests/_ast/test_load.py::TestGetStatus::test_get_status[test_get_app_kwargs-valid] - AssertionError: assert 'has_errors' == 'valid'
FAILED tests/_ast/test_load.py::TestGetStatus::test_get_status[test_generate_filecontents_empty_with_config-valid] - AssertionError: assert 'has_errors' == 'valid'
FAILED tests/_ast/test_load.py::TestGetStatus::test_get_status[test_generate_filecontents_empty-empty] - AssertionError: assert 'has_errors' == 'empty'
FAILED tests/_ast/test_load.py::TestGetStatus::test_get_status[test_app_with_no_cells-empty] - AssertionError: assert 'has_errors' == 'empty'
FAILED tests/_ast/test_load.py::TestGetStatus::test_get_status[test_app_with_only_comments-empty] - AssertionError: assert 'invalid' == 'empty'
FAILED tests/_ast/test_load.py::TestGetStatus::test_get_status[test_non_marimo-invalid] - marimo._ast.parse.MarimoFileError: `marimo.App` definition expected.
FAILED tests/_ast/test_load.py::TestGetStatus::test_get_status[test_syntax_errors-has_errors] - AssertionError: assert 'valid' == 'has_errors'
FAILED tests/_ast/test_load.py::TestGetStatus::test_get_status[test_with_bad_decorator-has_errors] - AssertionError: assert 'valid' == 'has_errors'
FAILED tests/_ast/test_load.py::TestGetStatus::test_get_status[test_get_codes_with_incorrect_args_rets-has_errors] - AssertionError: assert 'valid' == 'has_errors'
FAILED tests/_ast/test_load.py::TestGetStatus::test_get_status[test_get_codes_with_name_error-has_errors] - AssertionError: assert 'valid' == 'has_errors'
FAILED tests/_ast/test_load.py::TestGetStatus::test_get_status[test_generate_filecontents_with_syntax_error-has_errors] - AssertionError: assert 'valid' == 'has_errors'

@dmadisetti dmadisetti force-pushed the ms/test-notebook-status branch from 5f3627d to 5b2d900 Compare October 30, 2025 19:55
@dmadisetti dmadisetti force-pushed the ms/test-notebook-status branch from 7dc81fa to c52641f Compare October 30, 2025 20:00
@mscolnick mscolnick closed this Oct 30, 2025
@dmadisetti dmadisetti mentioned this pull request Oct 30, 2025
Merged
mscolnick added a commit that referenced this pull request Oct 30, 2025
@dmadisetti @mscolnick @pre-commit-ci
fix: ensure correct markdown serialization (#7016)
1b61c86 
## 📝 Summary

Continuation of #7013
Very aggressive verification that markdown correctly serializes now.

---------

Co-authored-by: Myles Scolnick <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmadisetti dmadisetti Awaiting requested review from dmadisetti dmadisetti will be requested when the pull request is marked ready for review dmadisetti is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mscolnick @dmadisetti