fix: simplify markdown #7005
Merged
fix: simplify markdown #7005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
i'd prefer to not do this (led to previous bug) and instead keep this logic simple |
|
this changes (always choosing multi-line) is better now. I think it makes sense since not to have nuanced logic when it would go from single-line to multi-line. and as a result, no gotchas to the user for when that changes for various reasons like:
|
dmadisetti
requested review from
Light2Dark,
akshayka and
manzt
as code owners
mscolnick
approved these changes
Oct 30, 2025
mscolnick
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Simplifies markdown logic from separating multiline and single line cases to always using multiline. This mitigates a breaking bug in 0.17.3 where long single lines had a spurious
"resulting in an unparsable notebook.