Skip to content

Conversation

@Light2Dark
Copy link
Contributor

@Light2Dark Light2Dark commented Oct 30, 2025

📝 Summary

There's a bug where sql statements like this would reference itself.

CREATE TABLE my_table AS SELECT * FROM schema_one.my_table

We should skip if we find a referenced cell_id == current_cell_id.

This is happening because the function to find references searches through all the defs in the graph, so it will definitely find itself.

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

@vercel
Copy link

vercel bot commented Oct 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Oct 30, 2025 2:24pm

mscolnick
mscolnick previously approved these changes Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants