Skip to content

Conversation

@bjoaquinc
Copy link
Contributor

@bjoaquinc bjoaquinc commented Oct 29, 2025

📝 Summary

This moves getting all active notebooks to ToolContext so it can be accessed by both GetActiveNotebooks tool and ActiveNotebooks prompt.

🔍 Description of Changes

It also does the following:

  • Add better handling of no filepath (for new notebook that hasn't been saved yet)
  • Remove unused or redundant notebook info for both tool and prompt
  • Create a base MarimoNotebookInfo dataclass where sessionId is not Optional
  • Change next-steps in GetActiveNotebooks from GetCellRuntimeData to GetNotebookErrors since it makes more sense
  • Change from using filename (or relative filepath) to always using absolute filepath for agent edit notebook tools
  • Improve GetActiveNotebooks tests

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

@vercel
Copy link

vercel bot commented Oct 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Oct 29, 2025 1:55am

Copy link
Contributor

@mscolnick mscolnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup

@mscolnick mscolnick merged commit 325eb40 into marimo-team:main Oct 29, 2025
25 of 37 checks passed
@bjoaquinc bjoaquinc deleted the errors-prompt branch October 29, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants