Skip to content

improvement: handle nested sql statements for sql smart cells #6947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2025
Merged

improvement: handle nested sql statements for sql smart cells #6947

merged 1 commit into from
Oct 27, 2025

Conversation

@mscolnick
Copy link
Contributor

@mscolnick mscolnick commented Oct 27, 2025 •
edited by Light2Dark
Loading

Fixes #6882. This handles nested SQL in the SQL parsing logic for sql smart cells:

e.g.

     SELECT
        id AS idid,
        value as valval
    FROM
        sample_data
    WHERE
        id IN ({",".join(df["id"][0:2].to_list())})

@vercel
Copy link

vercel bot commented Oct 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Oct 27, 2025 4:06pm

@mscolnick mscolnick merged commit ee80bd1 into main Oct 27, 2025
26 checks passed
@mscolnick mscolnick deleted the ms/better-sql-parsing-nested branch October 27, 2025 16:15
@mscolnick mscolnick added the enhancement New feature or request label Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Light2Dark Light2Dark Light2Dark approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SQL cell scrambled by Format cell

3 participants

@mscolnick @Light2Dark