Skip to content

Conversation

@Light2Dark
Copy link
Contributor

@Light2Dark Light2Dark commented Oct 24, 2025

📝 Summary

Updated the condition for checking the existence of the setup cell to use state.cellIds instead of state.cellData.
When deleteCell is called, it removes from cellIds, not cellData

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

Updated the condition for checking the existence of the setup cell to use `state.cellIds` instead of `state.cellData`. When deleteCell is called, it removes from cellIds, not cellData
@Light2Dark Light2Dark requested a review from manzt as a code owner October 24, 2025 08:21
@vercel
Copy link

vercel bot commented Oct 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Oct 24, 2025 8:22am

@mscolnick mscolnick merged commit b6d76da into main Oct 24, 2025
26 checks passed
@mscolnick mscolnick deleted the sham/fix-add-setup-cell-deleted branch October 24, 2025 13:38
@dmadisetti dmadisetti added the bug Something isn't working label Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants