Skip to content

improvement: implement ReconnectingWebSocketTransport for improved WebSocket handling #6909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2025
Merged

improvement: implement ReconnectingWebSocketTransport for improved WebSocket handling #6909

merged 2 commits into from
Oct 24, 2025

Conversation

@mscolnick
Copy link
Contributor

Added a new ReconnectingWebSocketTransport class to manage WebSocket connections with automatic reconnection capabilities. This can happen whenever a computer goes to sleep

Fixes #6903

@mscolnick
improvement: implement ReconnectingWebSocketTransport for improved We…
2deb3d9 
…bSocket handling

Added a new ReconnectingWebSocketTransport class to manage WebSocket connections with automatic reconnection capabilities. This can happen whenever a computer goes to sleep

Fixes #6903
@vercel
Copy link

vercel bot commented Oct 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Oct 23, 2025 10:07pm

@mscolnick mscolnick requested a review from akshayka October 23, 2025 22:06
dmadisetti
dmadisetti approved these changes Oct 23, 2025
View reviewed changes
Copy link
Collaborator

@dmadisetti dmadisetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to hold off on disabling pylsp? Seems like this might fix it in certain cases

@akshayka
Copy link
Contributor

Do we want to hold off on disabling pylsp? Seems like this might fix it in certain cases

We can disable (to immediately solve the issue at hand) and re-eanble if this fixes it later

@mscolnick mscolnick merged commit 4255117 into main Oct 24, 2025
26 checks passed
@mscolnick mscolnick deleted the ms/reconecting-lsp branch October 24, 2025 00:42
@dmadisetti dmadisetti added the enhancement New feature or request label Oct 24, 2025
@mscolnick mscolnick mentioned this pull request Oct 28, 2025
Merged
mscolnick added a commit that referenced this pull request Oct 29, 2025
@mscolnick
fix: re-initialize LSP on reconnect (#6967)
84a992b 
Closes #6903 again

This is a followup from #6909.
This appeared to work, but only in development. We need to explicitly
call `client.initialize()` again (in development this was refresh and
automatically called)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akshayka akshayka akshayka approved these changes

@dmadisetti dmadisetti dmadisetti approved these changes

@manzt manzt Awaiting requested review from manzt manzt is a code owner

@Light2Dark Light2Dark Awaiting requested review from Light2Dark Light2Dark is a code owner

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

intellisense does not work in macOs after sleep

4 participants

@mscolnick @akshayka @dmadisetti