Skip to content

Conversation

@mscolnick
Copy link
Contributor

@mscolnick mscolnick commented Oct 23, 2025

LSP still have issues (seem more so on windows users), so making the default use our own completions API rather than the LSP + requiring additional deps.

@vercel
Copy link

vercel bot commented Oct 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Oct 24, 2025 0:55am

dmadisetti
dmadisetti previously approved these changes Oct 23, 2025
Copy link
Collaborator

@dmadisetti dmadisetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snapshots seem pretty brittle. Maybe that's a feature not a bug?

akshayka
akshayka previously approved these changes Oct 24, 2025
@mscolnick mscolnick dismissed stale reviews from akshayka and dmadisetti via 4755ea0 October 24, 2025 00:54
@mscolnick mscolnick merged commit fe6a08a into main Oct 24, 2025
39 of 41 checks passed
@mscolnick mscolnick deleted the ms/disable-lsp branch October 24, 2025 03:19
@dmadisetti dmadisetti added the bug Something isn't working label Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants