improvement: print matplotlib Figures/Axes in rich table output #6904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `narwhals_table.py` to handle of Pillow images and Matplotlib figures
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Light2Dark
reviewed
Oct 23, 2025
There was a problem hiding this comment.
don't think this file is needed
There was a problem hiding this comment.
its just a smoke test, i don't see any harm in having a repro commited to the codebase
There was a problem hiding this comment.
okay, it just seemed irrelevant to this issue & a normal duckdb error. but okay to include
Co-authored-by: Shahmir Varqha <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Shahmir Varqha <[email protected]>
for more information, see https://pre-commit.ci
Light2Dark
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6893
Print matplotlib Figures/Axes in rich table output. Updated
narwhals_table.pyto handle of Pillow images and Matplotlib figures