Skip to content

Conversation

@mscolnick
Copy link
Contributor

@mscolnick mscolnick commented Oct 23, 2025

Adds Codex to the available agents in the ACP sidebar and many other fixes:

  • Add Codex command to the Agent dropdown
  • Disable bottom buttons when the agent is running
  • Dedupe todos/plans (in case they have status updates)
  • some tools don't send a completion update, so we just always mark them completed if they are no longer the last block
  • Collapse unchanged regions in the diff viewer
  • Handle edge case when Claude ACP returns a different schema than the ACP protocol expects for diffs (HACK: if the raw input is abs_path, old_string, new_string then handle it as if it is a diff)
  • Handle edge case were the title comes back "undefined" from the ACP
image Screenshot 2025-10-27 at 4 25 16 PM Screenshot 2025-10-27 at 4 24 14 PM

@vercel
Copy link

vercel bot commented Oct 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Oct 28, 2025 1:26pm

Adds Codex to the available agents in the ACP sidebar
@dmadisetti dmadisetti added includes-media Description includes multimedia provided to illustrate functionality. release-highlight A feature or change to call out in upcoming release notes labels Oct 27, 2025
Copy link
Collaborator

@dmadisetti dmadisetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to pnpm add vega-util to build- but might be user error and/ or unrelated churn.
Wasn't able to login out the box:

[Server → Client]: {
  jsonrpc: '2.0',
  id: 0,
  result: {
    protocolVersion: 1,
    agentCapabilities: {
      loadSession: false,
      promptCapabilities: { image: true, audio: false, embeddedContext: true },
      mcpCapabilities: { http: true, sse: false }
    },
    authMethods: [
      {
        id: 'chatgpt',
        name: 'Login with ChatGPT',
        description: 'Use your ChatGPT login with Codex CLI (requires a paid ChatGPT subscription)'
      },
      {
        id: 'codex-api-key',
        name: 'Use CODEX_API_KEY',
        description: 'Requires setting the `CODEX_API_KEY` environment variable.'
      },
      {
        id: 'openai-api-key',
        name: 'Use OPENAI_API_KEY',
        description: 'Requires setting the `OPENAI_API_KEY` environment variable.'
      }
    ],
    agentInfo: { name: 'codex-acp', title: 'Codex', version: '0.3.10' }
  }
}
[stdio-to-ws] Child stderr: 2025-10-27T21:49:55.345020Z ERROR codex_core::codex: Failed to create session: cwd is not absolute: ""

[Server → Client]: {
  jsonrpc: '2.0',
  id: 1,
  error: { code: -32603, message: 'Internal error' }
}

Also tried the API_KEY. But codex by itself does work. Notice codex is slow, but I think that's just codex in general.

Changes look good by themselves

Light2Dark
Light2Dark previously approved these changes Oct 28, 2025
if (title === '"undefined"') {
title = undefined;
}
const prefix = title || Strings.startCase(item.kind || "") || "Tool call";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be this?

Suggested change
const prefix = title || Strings.startCase(item.kind || "") || "Tool call";
const prefix = title || (item.kind ? Strings.startCase(item.kind) : "Tool call");

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it evaluates to the same

@mscolnick mscolnick merged commit e4773cb into main Oct 28, 2025
26 checks passed
@mscolnick mscolnick deleted the ms/codex-acp branch October 28, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

includes-media Description includes multimedia provided to illustrate functionality. release-highlight A feature or change to call out in upcoming release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants