- 
                Notifications
    You must be signed in to change notification settings 
- Fork 748
feat: add support for Codex agent #6901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| The latest updates on your projects. Learn more about Vercel for GitHub. 
 | 
Adds Codex to the available agents in the ACP sidebar
f21edfb    to
    367af24      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to pnpm add vega-util to build- but might be user error and/ or unrelated churn.
Wasn't able to login out the box:
[Server → Client]: {
  jsonrpc: '2.0',
  id: 0,
  result: {
    protocolVersion: 1,
    agentCapabilities: {
      loadSession: false,
      promptCapabilities: { image: true, audio: false, embeddedContext: true },
      mcpCapabilities: { http: true, sse: false }
    },
    authMethods: [
      {
        id: 'chatgpt',
        name: 'Login with ChatGPT',
        description: 'Use your ChatGPT login with Codex CLI (requires a paid ChatGPT subscription)'
      },
      {
        id: 'codex-api-key',
        name: 'Use CODEX_API_KEY',
        description: 'Requires setting the `CODEX_API_KEY` environment variable.'
      },
      {
        id: 'openai-api-key',
        name: 'Use OPENAI_API_KEY',
        description: 'Requires setting the `OPENAI_API_KEY` environment variable.'
      }
    ],
    agentInfo: { name: 'codex-acp', title: 'Codex', version: '0.3.10' }
  }
}
[stdio-to-ws] Child stderr: 2025-10-27T21:49:55.345020Z ERROR codex_core::codex: Failed to create session: cwd is not absolute: ""
[Server → Client]: {
  jsonrpc: '2.0',
  id: 1,
  error: { code: -32603, message: 'Internal error' }
}
Also tried the API_KEY. But codex by itself does work. Notice codex is slow, but I think that's just codex in general.
Changes look good by themselves
| if (title === '"undefined"') { | ||
| title = undefined; | ||
| } | ||
| const prefix = title || Strings.startCase(item.kind || "") || "Tool call"; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be this?
| const prefix = title || Strings.startCase(item.kind || "") || "Tool call"; | |
| const prefix = title || (item.kind ? Strings.startCase(item.kind) : "Tool call"); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it evaluates to the same
Co-authored-by: Shahmir Varqha <[email protected]>
Adds Codex to the available agents in the ACP sidebar and many other fixes:
HACK: if the raw input isabs_path,old_string,new_stringthen handle it as if it is a diff)"undefined"from the ACP