Skip to content

Conversation

@Light2Dark
Copy link
Contributor

📝 Summary

Better support multi-column edits by letting the AI pass column index instead of ID. This allows to add cells at the end of specific columns. The backend doesn't hold the same column id as the frontend, so this is better to do.

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

@Light2Dark Light2Dark requested a review from manzt as a code owner October 23, 2025 03:35
@vercel
Copy link

vercel bot commented Oct 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Oct 23, 2025 3:36am

Copy link
Contributor

@mscolnick mscolnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. i also wonder if we can make the schema and instructions conditional on column mode actually being activated

@Light2Dark
Copy link
Contributor Author

a bit tricky since the tools are registered on start. Maybe subscribe to an atom and change the tool instructions.

@Light2Dark Light2Dark merged commit 4585075 into main Oct 24, 2025
26 checks passed
@Light2Dark Light2Dark deleted the sham/support-multi-column-edits branch October 24, 2025 03:59
@dmadisetti dmadisetti added the bug Something isn't working label Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants