improvement: fallbacks and warnings for missing features from sandboxed iframes + docs #6883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed iframes + docs
mscolnick
requested review from
Light2Dark,
akshayka and
manzt
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
bot
added
the
documentation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mscolnick
commented
Oct 22, 2025
| There are various ways to embed marimo notebooks in other web pages, such | ||
| There are various ways to embed marimo notebooks in other web pages, such | ||
| as web documentation, educational platforms, or static sites in general. Here | ||
| are two ways: |
There was a problem hiding this comment.
classic off-by-one error
dmadisetti
reviewed
Oct 22, 2025
| <iframe | ||
| src="https://marimo.app/your-notebook" | ||
| sandbox="allow-scripts allow-same-origin allow-downloads allow-popups" | ||
| allow="microphone" |
There was a problem hiding this comment.
not needed for our components
|
|
||
| **Permission Policy:** | ||
|
|
||
| * **`allow="microphone"`**: Required for `mo.ui.microphone()` widget functionality |
There was a problem hiding this comment.
Ahh ok. We could add mo.ui.webcam at some point. But probably with demand
| function detectIframeCapabilities(): IframeCapabilities { | ||
| const isEmbedded = window.parent !== window; | ||
|
|
||
| const capabilities: IframeCapabilities = { |
There was a problem hiding this comment.
Surprised there isn't a more native way. Not much of a penalty?
dmadisetti
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve support and documentation for embedding marimo notebooks in sandboxed iframes, and adds runtime detection of iframe capabilities to the frontend (with improved warnings and fallbacks).