Skip to content

Conversation

@Light2Dark
Copy link
Contributor

📝 Summary

  • subtler left bar to create new cells (create above opens a dropdown, create below is as normal)
  • in between cells a few buttons appear
CleanShot.2025-10-21.at.02.09.32.mp4

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

@vercel
Copy link

vercel bot commented Oct 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Oct 21, 2025 3:04am

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

@akshayka
Copy link
Contributor

Oh nice! The + buttons look nice. I wonder if they should be positioned at the top and bottom of the entire cell, including outputs, instead of just the top and bottom of the code editor. I'm looking at the below frame in particular. cc @manzt

image

@manzt
Copy link
Contributor

manzt commented Oct 20, 2025

Really nice putting this together. I pulled it down and tried it out. Overall, I prefer the left sidebar + (over the 1 click actions) and agree with @akshayka that having the + ---- + span the full cell (including outputs) would be nice to position the buttons closer to where the action takes place.

Probably just a impl detail, but i noticed that the add above and add below actions are slightly different. Top opens a popover to select a cell kind; bottom inserts a Python cell. I like the popover because we have other quick actions to add cells (keyboard shortcuts), and it gives us some future real estate should we ever want to expand what a user can insert (e.g., snippets, ai)

@Light2Dark
Copy link
Contributor Author

Light2Dark commented Oct 21, 2025

CleanShot.2025-10-21.at.11.03.15.mp4

Thanks @manzt @akshayka , I made some improvements to the prototype:

  • plus buttons span the entire cell
  • remove vertical line (you can increase the opacity to see it, but i felt it was noisy)
  • only 1 button for the in-between cell action with dropdown

i like both options now, we can discuss specific behaviours (on-click, right click, shift+click) later.

Items to resolve:

  • which design
  • on 1 click, do what. right click? shift+click?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants