fix: Support git dependencies in sandboxed script metadata (#5545) #6827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Fixes an issue where adding git dependencies via the UI (e.g., `git+https://github.com/user/repo.git`) would install the package successfully but fail to update the script's inline metadata with the required `[tool.uv.sources]` section. ## Changes - Modified `UvPackageManager.update_notebook_script_metadata()` to detect and handle direct reference dependencies (git URLs, direct URLs, local paths) - Added `_is_direct_reference()` helper function to identify packages that should bypass the installed packages check - Direct references are now passed through to `uv add --script` which correctly creates the `[tool.uv.sources]` section Closes #5545
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dmadisetti
reviewed
Oct 17, 2025
Comment on lines
+261
to
+262
| if "://" in package: | ||
| return True |
There was a problem hiding this comment.
Couldn't we do just this?
dmadisetti
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where adding git dependencies via the UI (e.g.,
git+https://github.com/user/repo.git) would install the package successfully but fail to update the script's inline metadata with the required[tool.uv.sources]section.Changes
UvPackageManager.update_notebook_script_metadata()to detect and handle direct reference dependencies (git URLs, direct URLs, local paths)_is_direct_reference()helper function to identify packages that should bypass the installed packages checkuv add --scriptwhich correctly creates the[tool.uv.sources]sectionCloses #5545