Skip to content

Conversation

@Light2Dark
Copy link
Contributor

@Light2Dark Light2Dark commented Oct 15, 2025

📝 Summary

I removed 'delete cell' for now, it needs a special UI to display cells that are deleted and to revert

CleanShot.2025-10-17.at.02.10.24.mp4

Todo in follow-ups:

  • floating label for edits made with accept all & reject all
  • support deletes
  • support multi-column edits better

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

@vercel
Copy link

vercel bot commented Oct 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Oct 17, 2025 2:17pm

@github-actions github-actions bot added the bash-focus Area to focus on during release bug bash label Oct 15, 2025
@github-actions
Copy link

Breaking changes detected in the OpenAPI specification!

@Light2Dark Light2Dark force-pushed the sham/edit-notebook-tool branch from cb24822 to b34f6e2 Compare October 16, 2025 09:22
@github-actions
Copy link

Breaking changes detected in the OpenAPI specification!

@github-actions
Copy link

Breaking changes detected in the OpenAPI specification!

@github-actions
Copy link

Breaking changes detected in the OpenAPI specification!

@github-actions
Copy link

Breaking changes detected in the OpenAPI specification!

@github-actions
Copy link

Breaking changes detected in the OpenAPI specification!

@github-actions
Copy link

Breaking changes detected in the OpenAPI specification!

@github-actions
Copy link

Breaking changes detected in the OpenAPI specification!

@Light2Dark Light2Dark marked this pull request as ready for review October 17, 2025 02:25
@Light2Dark Light2Dark requested a review from manzt as a code owner October 17, 2025 02:25
@Light2Dark Light2Dark requested a review from mscolnick October 17, 2025 02:25
mscolnick
mscolnick previously approved these changes Oct 17, 2025
## 📝 Summary

<!--
Provide a concise summary of what this pull request is addressing.

If this PR fixes any issues, list them here by number (e.g., Fixes
#123).
-->


https://github.com/user-attachments/assets/05af6efe-65c2-4312-9571-f0cb88c378a6

## 🔍 Description of Changes

<!--
Detail the specific changes made in this pull request. Explain the
problem addressed and how it was resolved. If applicable, provide before
and after comparisons, screenshots, or any relevant details to help
reviewers understand the changes easily.
-->

## 📋 Checklist

- [x] I have read the [contributor
guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md).
- [x] For large changes, or changes that affect the public API: this
change was discussed or approved through an issue, on
[Discord](https://marimo.io/discord?ref=pr), or the community
[discussions](https://github.com/marimo-team/marimo/discussions) (Please
provide a link if applicable).
- [x] I have added tests for the changes made.
- [x] I have run the code and verified that it works as expected.
@github-actions
Copy link

Breaking changes detected in the OpenAPI specification!

@github-actions
Copy link

Breaking changes detected in the OpenAPI specification!

@Light2Dark Light2Dark added enhancement New feature or request preview Experimental or preview-only feature labels Oct 18, 2025
@Light2Dark Light2Dark requested a review from mscolnick October 20, 2025 02:13
@mscolnick mscolnick merged commit 6cd3329 into main Oct 20, 2025
35 of 63 checks passed
@mscolnick mscolnick deleted the sham/edit-notebook-tool branch October 20, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bash-focus Area to focus on during release bug bash enhancement New feature or request preview Experimental or preview-only feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants