Skip to content

Set cursor-pointer for button #6775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2025
+9 −8
Merged

Set cursor-pointer for button #6775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e872c8
Set cursor-pointer for buttons by default
sebkur Oct 14, 2025
473440a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/components/editor/chrome/wrapper/sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ const SidebarItem: React.FC<
<Tooltip content={tooltip} side="right" delayDuration={200}>
<button
className={cn(
"flex items-center p-2 text-sm mx-px shadow-inset font-mono cursor-pointer rounded",
"flex items-center p-2 text-sm mx-px shadow-inset font-mono rounded",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, the sidebar is a good example, it no longer needs cursor-pointer here now.

!selected && "hover:bg-(--sage-3)",
selected && "bg-(--sage-4)",
className,
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/editor/inputs/Inputs.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { cva } from "class-variance-authority";
import "./Inputs.css";

export const button = cva(
"flex items-center justify-center m-0 leading-none font-medium border border-foreground/10 shadow-xs-solid hover:cursor-pointer active:shadow-none dark:border-border text-sm",
"flex items-center justify-center m-0 leading-none font-medium border border-foreground/10 shadow-xs-solid active:shadow-none dark:border-border text-sm",
{
variants: {
color: {
Expand Down
5 changes: 5 additions & 0 deletions frontend/src/css/globals.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,11 @@
a.hyperlink:hover {
text-decoration: underline;
}

button:not(:disabled),
[role="button"]:not(:disabled) {
cursor: pointer;
}
}

@theme {
Expand Down
4 changes: 1 addition & 3 deletions frontend/src/plugins/impl/FileBrowserPlugin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,9 +475,7 @@ export const FileBrowser = ({
selected
</span>
<button
className={cn(
"text-xs text-destructive hover:underline cursor-pointer",
)}
className={cn("text-xs text-destructive hover:underline")}
onClick={() => setValue([])}
type="button"
>
Expand Down
4 changes: 1 addition & 3 deletions frontend/src/plugins/impl/FileUploadPlugin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,7 @@ export const FileUpload = (props: FileUploadProps): JSX.Element => {
</Tooltip>

<button
className={cn(
"text-xs cursor-pointer text-destructive hover:underline",
)}
className={cn("text-xs text-destructive hover:underline")}
onClick={() => setValue([])}
type="button"
>
Expand Down
Loading