handle big ints better #6768
Merged
handle big ints better #6768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mscolnick
previously approved these changes
Oct 14, 2025
frontend/src/custom.d.ts
Outdated
| reviver?: (this: any, key: string, value: any) => any, | ||
| ): unknown; | ||
|
|
||
| rawJSON(value: string): any; |
There was a problem hiding this comment.
is this better as rawJSON(value: string): unknown?
mscolnick
previously approved these changes
Oct 14, 2025
mscolnick
reviewed
Oct 14, 2025
| const bigint = 2 ** 64; | ||
| const value = `text/plain+bigint:${bigint}`; | ||
| const result = getCopyValue(value); | ||
| expect(result).toMatchInlineSnapshot(`"18446744073709552000"`); |
There was a problem hiding this comment.
this seems rounded 2 ** 64
There was a problem hiding this comment.
it should be 18446744073709551616
There was a problem hiding this comment.
oops, yeah, I think the test is inaccurate because 2 ** 64 is going to be rounded. let me think of a way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
note that floats with big ints don't work well with tables, so I convert them to strings (which is the default rendering if using mo.plain)
before:
after:
🔍 Description of Changes
📋 Checklist