fix: format OpenAPI generated files after codegen in build script #6739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build script now runs 'pnpm format packages/openapi/' after the turbo build completes. This ensures generated OpenAPI client files match the formatting of tracked files, preventing dirty working tree after 'make fe'.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dmadisetti
approved these changes
Oct 10, 2025
mscolnick
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pnpm format packages/openapi/tobuildfrontend.shafter the turbo build completesmake feBackground
The
make fecommand runsbuildfrontend.sh, which invokespnpm turbo build. This triggers thecodegentask which regenerates OpenAPI client files usingopenapi-typescript. However, these files are output in raw generator style (4-space indentation, unions collapsed to one line), while the tracked versions in the repository are properly formatted.The
make fe-codegentarget already includes the formatting step (pnpm format packages/openapi/), butmake fewas missing it, causing formatting diffs every time the build ran.Testing
make fenow produces no git diffs for OpenAPI files