Skip to content

Conversation

@mscolnick
Copy link
Contributor

@mscolnick mscolnick commented Oct 10, 2025

Fixes #5748

Summary

Package manager commands (pip, uv, poetry, pixi) now explicitly use UTF-8 encoding when calling subprocess, fixing crashes on Windows systems with non-UTF-8 locales (e.g., GBK on Chinese Windows).

@mscolnick mscolnick requested a review from dmadisetti as a code owner October 10, 2025 04:53
@vercel
Copy link

vercel bot commented Oct 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Oct 10, 2025 5:47am

@mscolnick mscolnick changed the title fix: utf8 for package management commands fix: use UTF-8 encoding for subprocess calls in package managers Oct 10, 2025
@mscolnick mscolnick requested a review from manzt October 10, 2025 04:54
dmadisetti
dmadisetti previously approved these changes Oct 10, 2025
@mscolnick mscolnick added the bug Something isn't working label Oct 10, 2025
@mscolnick mscolnick merged commit 7cb0239 into main Oct 10, 2025
37 of 41 checks passed
@mscolnick mscolnick deleted the ms/utf8-pip-list branch October 10, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

packages error 'NoneType' object has no attribute 'strip'

3 participants