DRY common package managers install logic #6685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dmadisetti
requested changes
Oct 5, 2025
yairchu
force-pushed
the
install-commands
branch
from
9aa30f9 to
69b347f
Compare
|
Also passing CI if you don't mind (just a few import deletions) https://results.pre-commit.ci/run/github/678526156/1759731371.W4HPrCcLRxCk3SwUIr1C_w |
yairchu
force-pushed
the
install-commands
branch
from
69b347f to
852e080
Compare
Done, as well as other typing errors etc |
…thod (a preparation for marimo-team#6684 and good organization regardless)
yairchu
force-pushed
the
install-commands
branch
from
852e080 to
18f8b30
Compare
|
IIUC the failing CI test now is unrelated to this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This is a cleanup that deduplicates repeating code and in the process extracts the
install_commandmethod that will be needed by #6684🔍 Description of Changes
Package manager's
_installmethod contains duplication for all package managers except micropip. This change provides a default implementation that uses a newinstall_commandmethod, both making the code more modular and less repetitive and preparing for future additional uses of the new method.📋 Checklist