fix: Enable stub mechanism for caching un-pickable objects #6657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
for more information, see https://pre-commit.ci
mscolnick
reviewed
Oct 3, 2025
marimo/_save/stubs/__init__.py
Outdated
| return True | ||
|
|
||
| # Walk MRO to find matching base class | ||
| for cls in value_type.__mro__: |
There was a problem hiding this comment.
i did this in formatters, and it has a chance of raising errors in odd edge maybe either catch the exception or comment if we just want to propoage it up
There was a problem hiding this comment.
Nice, looked at the formatters change, and a little too small to meaningfully DRY- but hopefully this saves us a bug report
mscolnick
previously approved these changes
Oct 3, 2025
mscolnick
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
closes #5542
CustomStubclass which enables custom methods of hashing, saving, and restoring objects to and from cache.