Skip to content

Conversation

@Light2Dark
Copy link
Contributor

📝 Summary

There is poor formatting and column positioning for previous SQL errors, I think we can just return the error message, it contains all the information. Also easier to pass to the AI as context.

Previously:

postgres error

CleanShot 2025-10-02 at 02 20 04 Ster as s

duckdb

CleanShot 2025-10-02 at 02 20 26

After:

postgres

CleanShot 2025-10-02 at 02 38 07 CleanShot 2025-10-02 at 02 38 23

duckdb

CleanShot 2025-10-02 at 02 38 41

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

@vercel
Copy link

vercel bot commented Oct 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Oct 2, 2025 1:25am

@Light2Dark Light2Dark force-pushed the sham/sql-error-other-engines branch from 8c6a86e to 8fd0053 Compare October 2, 2025 01:24
@Light2Dark Light2Dark marked this pull request as ready for review October 2, 2025 02:03
@Light2Dark Light2Dark requested a review from manzt as a code owner October 2, 2025 02:03
@Light2Dark Light2Dark requested review from dmadisetti and removed request for manzt October 2, 2025 02:03
@mscolnick mscolnick merged commit ccd8b37 into main Oct 2, 2025
39 of 41 checks passed
@mscolnick mscolnick deleted the sham/sql-error-other-engines branch October 2, 2025 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants