slightly lighten dark mode comment in codemirror #6628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Light2Dark
changed the title
mscolnick
approved these changes
Oct 1, 2025
mscolnick
pushed a commit
that referenced
this pull request
Oct 1, 2025
## 📝 Summary Closes #6628 Previously the `--watch` code path only reported cell changes, not deletions. This PR modifies "changed cells" to include deleted cells such that they can be appropriately cleaned up on reload. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Reported on discord, which I felt was valid.
Now I feel it might be a very opinionated thing, but we could make it overridable by adding to globals.
before:
after:
🔍 Description of Changes
📋 Checklist