feat: MCP presets: marimo docs and context7 #6619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Breaking changes detected in the OpenAPI specification! |
|
Breaking changes detected in the OpenAPI specification! |
Light2Dark
previously approved these changes
Oct 1, 2025
marimo/_server/ai/mcp/types.py
Outdated
Comment on lines
16
to
28
| class MCPToolMeta(TypedDict): | ||
| """Metadata that marimo adds to MCP tools.""" | ||
|
|
||
| server_name: str | ||
| namespaced_name: str | ||
|
|
||
| class MCPToolWithMeta(Protocol): | ||
| """MCP Tool with marimo-specific metadata.""" | ||
|
|
||
| name: str | ||
| description: str | None | ||
| inputSchema: dict[str, Any] | ||
| meta: MCPToolMeta |
There was a problem hiding this comment.
unused? we could also move it out of typechecking imo.
| ) | ||
|
|
||
| try: | ||
| from marimo._server.ai.mcp import get_mcp_client |
There was a problem hiding this comment.
were there errors if this import moved to the top? I feel like importing within hides errors down the road
marimo/_server/ai/mcp/transport.py
Outdated
| read, write, *_ = await exit_stack.enter_async_context( | ||
| streamablehttp_client( | ||
| config["url"], | ||
| headers=config.get("headers") or {}, |
There was a problem hiding this comment.
Suggested change
| headers=config.get("headers") or {}, | |
| headers=config.get("headers", {}), |
|
|
||
| # Set up environment variables for the server process | ||
| env = os.environ.copy() | ||
| env.update(config.get("env") or {}) |
There was a problem hiding this comment.
Suggested change
| env.update(config.get("env") or {}) | |
| env.update(config.get("env", {))) |
| # Configure server parameters | ||
| server_params = StdioServerParameters( | ||
| command=config["command"], | ||
| args=config.get("args") or [], |
There was a problem hiding this comment.
Suggested change
| args=config.get("args") or [], | |
| args=config.get("args", []), |
marimo/_server/ai/mcp/config.py
Outdated
| Raises: | ||
| ValueError: If configuration type is not supported | ||
| """ | ||
| # Import here to avoid circular imports |
There was a problem hiding this comment.
Suggested change
| # Import here to avoid circular imports |
| name=name, | ||
| transport=MCPTransportType.STREAMABLE_HTTP, | ||
| config=config, | ||
| timeout=config.get("timeout") or 30.0, |
There was a problem hiding this comment.
Suggested change
| timeout=config.get("timeout") or 30.0, | |
| timeout=config.get("timeout", 30.0), |
|
Breaking changes detected in the OpenAPI specification! |
|
Breaking changes detected in the OpenAPI specification! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5379
This adds MCPs "presets". Users can add
marimoorcontext7and these MCP configs are defined in the marimo server.