Skip to content

add datasource AI context #6618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 1, 2025
Merged

add datasource AI context #6618

merged 6 commits into from
Oct 1, 2025

Conversation

@Light2Dark
Copy link
Contributor

@Light2Dark Light2Dark commented Oct 1, 2025 •
edited
Loading

📝 Summary

CleanShot 2025-10-01 at 19 36 39 CleanShot 2025-10-01 at 19 36 56

result:

CleanShot 2025-10-01 at 21 39 25

todo:

  • for internal engine, package all dataframes & internal tables
  • formatContext needs work
  • tests
  • new bug found (it tries to call tools even in manual mode.
  • bug(?), since we have the database tool, it will try to call that even if we pass the datasource schema.
  • improvement - it should write queries with the engine name

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

@vercel
Copy link

vercel bot commented Oct 1, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Oct 1, 2025 1:48pm

@Light2Dark Light2Dark changed the title add datasource context add datasource AI context Oct 1, 2025
@Light2Dark Light2Dark marked this pull request as ready for review October 1, 2025 14:27
@Light2Dark Light2Dark requested a review from manzt as a code owner October 1, 2025 14:27
mscolnick
mscolnick approved these changes Oct 1, 2025
View reviewed changes
Copy link
Contributor

@mscolnick mscolnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great!

@Light2Dark Light2Dark merged commit 4f4cebb into main Oct 1, 2025
25 checks passed
@Light2Dark Light2Dark deleted the sham/add-datasource-context branch October 1, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mscolnick mscolnick mscolnick approved these changes

@manzt manzt Awaiting requested review from manzt manzt is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Light2Dark @mscolnick