improvement: use lazy-frames for multi-step processing, include more tests #6608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
manzt
reviewed
Sep 30, 2025
| if can_narwhalify(data): | ||
| narwhals_data = nw.from_native(data) | ||
| for col, dtype in narwhals_data.schema.items(): | ||
| is_prev_lazy = isinstance(narwhals_data, nw.LazyFrame) |
There was a problem hiding this comment.
should we use the is_narwhals_lazyframe helper here too?
There was a problem hiding this comment.
yep good call. just updated in a followup PR
manzt
previously approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After moving to narwhals v2, we can support more dataframe types in certain codepaths and tests.
This also makes multi-step operations lazy to avoid incremental df states