Skip to content

fix zod schema type errors for data-table #6606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2025
Merged

fix zod schema type errors for data-table #6606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15e1d0a
fix zod schema type errors
Light2Dark Sep 30, 2025
6e00e9f
run pnpm dedupe
Light2Dark Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions frontend/src/plugins/impl/DataTablePlugin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,10 @@ type DataTableFunctions = {

type S = (number | string | { rowId: string; columnName?: string })[];

const cellHoverTextSchema = z
.record(z.string(), z.record(z.string(), z.string().nullable()))
.optional();

export const DataTablePlugin = createPlugin<S>("marimo-table")
.withData(
z.object({
Expand Down Expand Up @@ -267,7 +271,7 @@ export const DataTablePlugin = createPlugin<S>("marimo-table")
.record(z.string(), z.record(z.string(), z.object({}).passthrough()))
.optional(),
hoverTemplate: z.string().optional(),
cellHoverTexts: z.record(z.record(z.string().nullable())).optional(),
cellHoverTexts: cellHoverTextSchema,
// Whether to load the data lazily.
lazy: z.boolean().default(false),
// If lazy, this will preload the first page of data
Expand Down Expand Up @@ -313,9 +317,7 @@ export const DataTablePlugin = createPlugin<S>("marimo-table")
z.record(z.string(), z.object({}).passthrough()),
)
.nullable(),
cell_hover_texts: z
.record(z.record(z.string().nullable()))
.nullable(),
cell_hover_texts: cellHoverTextSchema,
}),
),
get_row_ids: rpc.input(z.object({}).passthrough()).output(
Expand Down Expand Up @@ -363,12 +365,7 @@ export const DataTablePlugin = createPlugin<S>("marimo-table")
data={props.data.data}
value={props.value}
setValue={props.setValue}
cellHoverTexts={
props.data.cellHoverTexts as Record<
string,
Record<string, string | null>
>
}
cellHoverTexts={props.data.cellHoverTexts}
/>
</LazyDataTableComponent>
</TableProviders>
Expand Down Expand Up @@ -490,10 +487,7 @@ export const LoadingDataTableComponent = memo(
let tableData = props.data;
let totalRows = props.totalRows;
let cellStyles = props.cellStyles;
let cellHoverTexts = props.cellHoverTexts as
| Record<string, Record<string, string | null>>
| undefined
| null;
let cellHoverTexts = props.cellHoverTexts;

const pageSizeChanged = paginationState.pageSize !== props.pageSize;

Expand Down
Loading
Loading