improvement: cache validation requests for sql linter #6574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mscolnick
commented
Sep 29, 2025
|
|
||
| try { | ||
| const result = await ValidateSQL.request({ | ||
| onlyParse: false, |
There was a problem hiding this comment.
@Light2Dark since onlyParse is true in one case but false in the other, the cache is not that effective. maybe they can both be true? or both false (for just duckdb)
There was a problem hiding this comment.
yeah, both can be false if in validate sql mode for duckdb.
mscolnick
commented
Sep 29, 2025
| @@ -1,74 +0,0 @@ | |||
| /* Copyright 2024 Marimo. All rights reserved. */ | |||
Light2Dark
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache SQL validation requests that are shared from the linter and banner