- 
                Notifications
    You must be signed in to change notification settings 
- Fork 748
enhancement(msgspec): create BaseStruct with __get_pydantic_core_schema__ class method and refactor MCP msgspec.Struct types to use it #6540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement(msgspec): create BaseStruct with __get_pydantic_core_schema__ class method and refactor MCP msgspec.Struct types to use it #6540
Conversation
…ion for typechecking
| The latest updates on your projects. Learn more about Vercel for GitHub. 
 | 
        
          
                marimo/_ai/_tools/tools/cells.py
              
                Outdated
          
        
      | if var_name in all_variables: | ||
| var_value = all_variables[var_name] | ||
| cell_variables[var_name] = CellVariableValue( | ||
| cell_variables[var_name] = VariableValue( | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could this just be cell_variables[var_name] = var_value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that makes sense. Done!
📝 Summary
Create BaseStruct to make msgspec.Struct types compatible with pydantic typechecking (for MCP Server tools). Update old code to now use this and remove redundant types.
This PR reverses the temporary fix implemented in #6265
🔍 Description of Changes
📋 Checklist