fix: add more expressions for SQL refs #6538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mscolnick
commented
Sep 26, 2025
| "drop table schema.cars; select * from cars", | ||
| set(), | ||
| {"mo", "cars"}, | ||
| {"mo", "cars", "schema.cars"}, |
There was a problem hiding this comment.
@dmadisetti , @Light2Dark , does this change look right?
There was a problem hiding this comment.
i think it looks right.
There was a problem hiding this comment.
I see a lot more failing tests, will check.
edit: oh, only fails on minimal deps, maybe old duckdb Tokenizer.
There was a problem hiding this comment.
module 'sqlglot.expressions' has no attribute 'Analyze'
im going to see if i can bump the minimum
Light2Dark
previously approved these changes
Sep 26, 2025
| "drop table schema.cars; select * from cars", | ||
| set(), | ||
| {"mo", "cars"}, | ||
| {"mo", "cars", "schema.cars"}, |
There was a problem hiding this comment.
i think it looks right.
Light2Dark
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6533
This adds more SQL expressions that capture refs.
Bumps sqlglot min dep to a version from Jan 2025