don't override auto-save by when in --watch mode #6535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 task
Co-authored-by: Trevor Manz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6534
Closes #4194
Closes #4196
This updates the behavior of watch mode in the server configuration to ensure that user-defined auto-save is kept, rather than being forcibly overridden. We had this originally enabled to avoid conflicts between the server's view of the file and external changes made from the filesystem. Since the cell matching has improved (#6127), I don't expect this to cause issues.
We can in a followup handle overwrites and show the user (similar to how vscode or other IDEs might handle this)