Fix anywidget initial buffer handling regression #6520
Merged
+298
−134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
manzt
force-pushed
the
push-xyvkqtvzwrmm
branch
from
d71038b to
3eca647
Compare
mscolnick
reviewed
Sep 24, 2025
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Myles Scolnick <[email protected]>
manzt
force-pushed
the
push-xyvkqtvzwrmm
branch
from
a02ace8 to
6a30380
Compare
|
Breaking changes detected in the OpenAPI specification! |
|
@mscolnick the frontend build popped up in another PR ... is that something with turbo? Also schema check failing just for the extra metadata (which i think is expected). |
mscolnick
approved these changes
Sep 25, 2025
|
Breaking changes detected in the OpenAPI specification! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6499
The
msgspecmigration changed how we encode "buffers" (aka binary blobs) in theUIElement.text, causing our frontend to dual-encode the responses.This commit properly decodes buffers at system boundaries by converting base64 strings to
DataViewobjects at two key points:SendUIElementMessageoperations in the WebSocket handlerI added several tests were we missed these changes, verifying that buffers are correctly encoded as base64 in HTML and properly handled in the Python backend.