add parse function in /validate endpoint for SQL #6517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Breaking changes detected in the OpenAPI specification! |
2 similar comments
|
Breaking changes detected in the OpenAPI specification! |
|
Breaking changes detected in the OpenAPI specification! |
|
Breaking changes detected in the OpenAPI specification! |
mscolnick
previously approved these changes
Sep 25, 2025
|
Breaking changes detected in the OpenAPI specification! |
Light2Dark
changed the title
|
Breaking changes detected in the OpenAPI specification! |
mscolnick
reviewed
Sep 25, 2025
|
Breaking changes detected in the OpenAPI specification! |
|
Breaking changes detected in the OpenAPI specification! |
1 similar comment
|
Breaking changes detected in the OpenAPI specification! |
|
Breaking changes detected in the OpenAPI specification! |
mscolnick
previously approved these changes
Sep 25, 2025
## 📝 Summary <!-- Provide a concise summary of what this pull request is addressing. If this PR fixes any issues, list them here by number (e.g., Fixes #123). --> Uses get_connection_for_sql (so we catch DBAPI and other queryEngines). Adds kernel tests for this codepath. Update parse tests introduced by Myles, but note that they aren't correct (many queries do not raise ParseErrors by duckdb) ## 🔍 Description of Changes <!-- Detail the specific changes made in this pull request. Explain the problem addressed and how it was resolved. If applicable, provide before and after comparisons, screenshots, or any relevant details to help reviewers understand the changes easily. --> ## 📋 Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [ ] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (Please provide a link if applicable). - [x] I have added tests for the changes made. - [x] I have run the code and verified that it works as expected.
Light2Dark
force-pushed
the
sham/parse-endpoint
branch
from
728ced0 to
f3973aa
Compare
|
Breaking changes detected in the OpenAPI specification! |
|
Breaking changes detected in the OpenAPI specification! |
|
I removed the |
Light2Dark
changed the title
Light2Dark
changed the title
mscolnick
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Adds a parse function in
/validateendpoint that currently supports duckdb so we get better lint errors when writing SQL cells./validate runs
SELECT JSON_SERIALIZE_SQLin duckdb, which returns a structured error response (for a majority of queries)https://duckdb.org/docs/stable/data/json/sql_to_and_from_json.html.
We then convert the json response to linter error format
A custom sql parser is created to use this new endpoint, everytime the parser runs
validateSqlfor DuckDB, it will call this endpoint instead of using NodeSqlParser default parsing.This PR also disables the
EXPLAINmode because they use the same endpoint and so there is a perf hit when called twice. We can optimize the endpoint.Endpoint design:
/sql/validateThere are 2 possible paths:
EXPLAIN {query}. Surfaces both syntax and catalog errors (invalid table_name etc.) but is not structured.When onlyParse is true, we just run the parse function, which is the aim of this PR. In the future, we want to optimize so that we can query once and get the complete response back.
🔍 Description of Changes
📋 Checklist