Skip to content

improvement: support 2-space markdown and paragraphs without newline before lists #6512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2025
Merged

improvement: support 2-space markdown and paragraphs without newline before lists #6512

merged 1 commit into from
Sep 25, 2025

Conversation

@mscolnick
Copy link
Contributor

@mscolnick mscolnick commented Sep 24, 2025 •
edited
Loading

Fixes #6510

This loosens some markdown limitations to act more like GitHub Flavored markdown (GFM) such that we allow:

  • 2 spaces for tabs
  • Lists can start after paragraph without an empty line
uv run marimo edit marimo/_smoke_tests/markdown/sane_lists.py

@mscolnick mscolnick requested a review from akshayka as a code owner September 24, 2025 14:34
@vercel
Copy link

vercel bot commented Sep 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Sep 24, 2025 2:36pm

@mscolnick mscolnick changed the title improvement: support 2-space markdown and paragraphs without lists improvement: support 2-space markdown and paragraphs without newline before lists Sep 24, 2025
dmadisetti
dmadisetti approved these changes Sep 25, 2025
View reviewed changes
Copy link
Collaborator

@dmadisetti dmadisetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't think perf is too much of an issue, but we might consider looking at all our plugins if it does. CI should now pass, so restarted the tests

@mscolnick mscolnick merged commit 6182a6d into main Sep 25, 2025
42 of 79 checks passed
@mscolnick mscolnick deleted the ms/markdown-lists branch September 25, 2025 02:03
@dmadisetti dmadisetti added the enhancement New feature or request label Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmadisetti dmadisetti dmadisetti approved these changes

@akshayka akshayka Awaiting requested review from akshayka akshayka is a code owner

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Markdown rendering too strict and incompatible with LLM-generated output

3 participants

@mscolnick @dmadisetti