feat: Wrap and pass SQL Errors #6498
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Breaking changes detected in the OpenAPI specification! |
|
Breaking changes detected in the OpenAPI specification! |
marimo/_sql/error_utils.py
Outdated
| import duckdb | ||
|
|
||
| if isinstance( | ||
| exception, (duckdb.duckdb.ParserException, duckdb.ProgrammingError) |
There was a problem hiding this comment.
can we handle catalog errors as well (duckdb might call them BinderErrors)
There was a problem hiding this comment.
Covered by ProgrammingError
marimo/_sql/error_utils.py
Outdated
| """Check if the exception is a SQL parsing error.""" | ||
| # Check for DuckDB exceptions first (most common) | ||
| try: | ||
| import duckdb |
There was a problem hiding this comment.
should we do DependencyManager.duckdb.imported() to avoid the import if not needed.
dmadisetti
force-pushed
the
dm/sql-plumb
branch
from
db51e77 to
b254618
Compare
for more information, see https://pre-commit.ci
|
Breaking changes detected in the OpenAPI specification! |
1 similar comment
|
Breaking changes detected in the OpenAPI specification! |
|
Breaking changes detected in the OpenAPI specification! |
1 similar comment
|
Breaking changes detected in the OpenAPI specification! |
dmadisetti
force-pushed
the
dm/sql-plumb
branch
from
e05afcd to
7fdf30d
Compare
for more information, see https://pre-commit.ci
|
Breaking changes detected in the OpenAPI specification! |
1 similar comment
|
Breaking changes detected in the OpenAPI specification! |
|
merging even though is breaks main, in order to unblock other folks |
📝 Summary
Starting point to format SQL errors in a bit more friendly manner. @Light2Dark let me know if you want to take over this branch, or create a PR against it.
Not sure what's up with my codegen? I can cherry pick the commit if it's a little too noisy.