Skip to content

Conversation

@mscolnick
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Sep 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Sep 23, 2025 5:09pm

@dmadisetti dmadisetti added the internal A refactor or improvement that is not user facing label Sep 23, 2025
@dmadisetti
Copy link
Collaborator

dmadisetti commented Sep 23, 2025

FAILED tests/_lint/test_sql_log_rules_snapshot.py::test_sql_parsing_errors_snapshot - Failed: Snapshot differs: '--- 
+++ 
@@ -1,6 +1,6 @@
-warning[sql-parse-error]: Expecting ). Line 19, Col: 21.
- --> tests/_lint/test_files/sql_parsing_errors.py:36:20
+warning[sql-parse-error]: Expecting ). Line 19, Col: 32.
+ --> tests/_lint/test_files/sql_parsing_errors.py:36:31
   36 |                 AND
   37 |                 descendants NOT NULL
-     |                       ^
+     |                                  ^
   38 |         )'

I think I just introduced this one. But the others fall under the same version replacement issue.
See #6496

@mscolnick mscolnick merged commit 1ba53d7 into main Sep 23, 2025
25 of 40 checks passed
@mscolnick mscolnick deleted the ms/skip-failing-text branch September 23, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal A refactor or improvement that is not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants