feat: Add markdown to the cell level #6479
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
marimo/_ast/compiler.py
Outdated
| markdown_lines = [ | ||
| line for line in code.strip().split("\n") if line.startswith("mo.md(") | ||
| ] | ||
| if len(markdown_lines) > 1: |
There was a problem hiding this comment.
this could be slightly cheaper some(line.startswith("mo.md(") for line in code.strip().split("\n")
There was a problem hiding this comment.
Nice- we don't actually need this check at all, ast parse handles this case.
There was a problem hiding this comment.
but isn't ast.parse more expensive. should we have a cheap check first and then actual parsing?
There was a problem hiding this comment.
the cheap one could even be "mo.md(" in code
There was a problem hiding this comment.
We have the have the ast already- so in those cases just directly use that, while allowing for the early stopping if extracted directly from code.
dmadisetti
force-pushed
the
dm/native-md
branch
from
7e2dcb3 to
0f2f471
Compare
|
|
||
| # Mark the cell as not stale (already "run") | ||
| CellOp.broadcast_stale(cell_id=cell_id, stale=False) | ||
| del execution_requests[cell_id] |
There was a problem hiding this comment.
any way to break some of this up outside of the Runner? its gotten quite large. i know it doesn't really belong in hooks, but maybe a function in the same file
There was a problem hiding this comment.
This is a good point, but we still call some functions on the object
📝 Summary
closes #5942
Extracts markdown on compilation level allowing for native rendering. On startup, before:
(auto off)
(auto on)
After:
(auto off)
(auto on)
printthere to ensure not loading from a session.json, but tests should capture this too.