Skip to content

Conversation

@nojaf
Copy link
Contributor

@nojaf nojaf commented Sep 22, 2025

📝 Summary

We would like to provide some (static) hover text on table header columns.

image

🔍 Description of Changes

I went with an approach similar to text_justify_columns.
The use-case if to further explain what the table does to other team members.

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

@vercel
Copy link

vercel bot commented Sep 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Sep 23, 2025 7:54am

@mscolnick
Copy link
Contributor

@nojaf i wonder if maybe this should be more descriptive like: header_info or header_descriptions. this way we can use it more in just hover? i would also propose putting it inside a little <InfoIcon/> to signify it has some info (because you may not cover all headers).

@Light2Dark what are your thoughts?

@Light2Dark
Copy link
Contributor

I like the InfoIcon idea too and use TooltipContent instead of title. The accurate name for this param would be header_tooltip I think, but do you think we would use this in diff ways @mscolnick .

some inspiration from ag-grid: https://www.ag-grid.com/javascript-data-grid/tooltips/#top

)


def _validate_header_hover_text(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add a test for this

@nojaf
Copy link
Contributor Author

nojaf commented Sep 22, 2025

image

@Light2Dark
Copy link
Contributor

hey @nojaf , would you mind fixing the test and lint errors. I will help to merge and clean up after that.

@nojaf
Copy link
Contributor Author

nojaf commented Sep 23, 2025

@Light2Dark I don't quite understand why tests like FAILED tests/_utils/test_uv_tree.py::test_complex_project_tree_raw_snapshot - AssertionError are no longer working.

@Light2Dark
Copy link
Contributor

thanks @nojaf , I'll have a look but I think unrelated. thanks for the work!

Copy link
Contributor

@Light2Dark Light2Dark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to make some improvements on this.

@Light2Dark Light2Dark merged commit 03129d6 into marimo-team:main Sep 23, 2025
21 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants