-
Notifications
You must be signed in to change notification settings - Fork 757
Add hover text on table header #6466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@nojaf i wonder if maybe this should be more descriptive like: @Light2Dark what are your thoughts? |
|
I like the InfoIcon idea too and use TooltipContent instead of title. The accurate name for this param would be header_tooltip I think, but do you think we would use this in diff ways @mscolnick . some inspiration from ag-grid: https://www.ag-grid.com/javascript-data-grid/tooltips/#top |
marimo/_plugins/ui/_impl/table.py
Outdated
| ) | ||
|
|
||
|
|
||
| def _validate_header_hover_text( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we add a test for this
|
hey @nojaf , would you mind fixing the test and lint errors. I will help to merge and clean up after that. |
This reverts commit e0cc5e4.
|
@Light2Dark I don't quite understand why tests like |
|
thanks @nojaf , I'll have a look but I think unrelated. thanks for the work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to make some improvements on this.
📝 Summary
We would like to provide some (static) hover text on table header columns.
🔍 Description of Changes
I went with an approach similar to
text_justify_columns.The use-case if to further explain what the table does to other team members.
📋 Checklist