feat 5834: add outline - mo.outline() #6430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mscolnick
reviewed
Sep 18, 2025
|
|
||
| render(props: IStatelessPluginProps<Data>): JSX.Element { | ||
| const { label } = props.data; | ||
| const { items } = store.get(notebookOutline); |
There was a problem hiding this comment.
this won't re-render on changes. you will need to create a new react component and then call useAtomValue(notebookOutline)
There was a problem hiding this comment.
you will want to wrap the component in a <Provider store={store} too
|
need to check that works as expected and write a few tests |
1 task
maxkoretskyi
force-pushed
the
f-5834
branch
from
1973a34 to
de44b9f
Compare
mscolnick
previously approved these changes
Sep 19, 2025
|
you will need to run the test |
maxkoretskyi
force-pushed
the
f-5834
branch
from
3f9e802 to
a042ed7
Compare
for more information, see https://pre-commit.ci
mscolnick
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Added mo.outline() element to show outline. Fixes 5834
🔍 Description of Changes