Skip to content

Conversation

@Light2Dark
Copy link
Contributor

@Light2Dark Light2Dark commented Sep 18, 2025

📝 Summary

Fetches tables (with schema, database and connection fields) in a database.
Supports regex queries.

CleanShot 2025-09-19 at 01 22 12 CleanShot 2025-09-19 at 01 24 20

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

@vercel
Copy link

vercel bot commented Sep 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Sep 19, 2025 3:14am

@Light2Dark Light2Dark marked this pull request as ready for review September 18, 2025 18:21

@dataclass
class GetDatabaseTablesOutput(SuccessResult):
tables: list[TableDetails] = field(default_factory=list)
Copy link
Contributor

@mscolnick mscolnick Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder if it would help to add an example sql: e.g. _df = mo.sql("SELECT * FROM database.schema.table LIMIT 100" in the response

)
)

return GetDatabaseTablesOutput(tables=tables)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to prevent duplicates?

mscolnick
mscolnick previously approved these changes Sep 18, 2025
@Light2Dark Light2Dark merged commit e985313 into main Sep 19, 2025
26 of 41 checks passed
@Light2Dark Light2Dark deleted the sham/add-datasource-tool branch September 19, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants