Skip to content

Conversation

@mscolnick
Copy link
Contributor

@mscolnick mscolnick commented Sep 18, 2025

This uses the react-aria i18n provider to set the locale for date inputs.

In a follow-up, I plan to make this configurable in user config (in case a user works for a US company, but based in another country, or vice-versa) and needs it set for reports

@vercel
Copy link

vercel bot commented Sep 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Sep 18, 2025 2:39am

Copy link
Contributor

@Light2Dark Light2Dark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this provider wrap islands too?
in web-components.tsx

@mscolnick
Copy link
Contributor Author

should this provider wrap islands too? in web-components.tsx

yep, it is there, right?

Copy link
Contributor

@Light2Dark Light2Dark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, looks good then.

@mscolnick mscolnick marked this pull request as draft September 18, 2025 13:03
@mscolnick mscolnick marked this pull request as ready for review September 18, 2025 21:26
@mscolnick mscolnick merged commit 299fc9a into main Sep 18, 2025
43 checks passed
@mscolnick mscolnick deleted the ms/use-locale branch September 18, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants