feat: lint pattern to extract and process logs (capture invalid sql) #6407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
bot
added
the
documentation
dmadisetti
force-pushed
the
dm/log-rule
branch
from
390987e to
54addc7
Compare
dmadisetti
force-pushed
the
dm/log-rule
branch
from
c0aff13 to
3e7fa8e
Compare
mscolnick
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Captures log information and formats it as a lint error if possible:
Added a
SQLErrorMetadata(TypedDict)we can potentially surface elsewhere: https://github.com/marimo-team/marimo/pull/6407/files#diff-ddd9a90856776e58792b931fec7c9a68366432991b6e9b0957f5731d0ae0aed6R22A bit more churn here because manually generating the graph opposed to going through
cell_managergives cell level granularity for log and error collection.Commit history is a bit messy because it has just been in the backlog, but let me know if you'd appreciate a rebase