-
Notifications
You must be signed in to change notification settings - Fork 794
fix: cast elements in list of enums to string for polars #5572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mscolnick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! i also added #5576 in order to handle the case were polars still fails (and we don't handle it)
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.14.11-dev29 |
…#5572) ## 📝 Summary <!-- Provide a concise summary of what this pull request is addressing. If this PR fixes any issues, list them here by number (e.g., Fixes marimo-team#123). --> Fixes marimo-team#5562. ## 🔍 Description of Changes <!-- Detail the specific changes made in this pull request. Explain the problem addressed and how it was resolved. If applicable, provide before and after comparisons, screenshots, or any relevant details to help reviewers understand the changes easily. --> ## 📋 Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [ ] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (Please provide a link if applicable). - [x] I have added tests for the changes made. - [x] I have run the code and verified that it works as expected. ## 📜 Reviewers <!-- Tag potential reviewers from the community or maintainers who might be interested in reviewing this pull request. Your PR will be reviewed more quickly if you can figure out the right person to tag with @ @mscolnick (General, AI) @dmadisetti (Runtime, Caching, Fileformat, AST) @manzt (Widgets, Dependency Management, LSP) @Light2Dark (Tables, Plots, Layouts, SQL) @akshayka (Public API, Dependencies, UX/Styling, Backend, Docs, Integrations) -->
…arimo-team#5576) marimo-team#5572 fixes an edge cases, but this also gracefully handles the unknown unknowns. "Gracefully" still throws and shows the error, but it does not crash the kernel.
📝 Summary
Fixes #5562.
🔍 Description of Changes
📋 Checklist
📜 Reviewers