improvement: style <progress/> consistently #4909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mscolnick
changed the title
3 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR improves the styling of progress bars for consistent appearance across Marimo native components and IPython outputs.
- Introduces a new IPython smoke test to simulate transformers training progress
- Adds new CSS styling in progress.css for progress elements
- Updates the main CSS index to import the new progress styles
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| marimo/_smoke_tests/ipython/progress.py | Added test cells simulating transformers training progress callbacks |
| frontend/src/css/progress.css | New CSS rules for consistent progress bar styling |
| frontend/src/css/index.css | Updated CSS imports with progress.css |
Comments suppressed due to low confidence (2)
marimo/_smoke_tests/ipython/progress.py:16
- [nitpick] The use of '_' as a function name is ambiguous and does not clearly convey its purpose. Consider renaming this function to a more descriptive name, such as 'simulate_training_progress' or similar.
def _(
marimo/_smoke_tests/ipython/progress.py:66
- [nitpick] Using '_' as a function name makes it unclear what functionality this cell provides. Renaming it to something descriptive would improve code clarity.
def _(IntervalStrategy):
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.13.8-dev21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some tweaks off of #4823