feat: add mathjax lib using useScript #2839
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Light2Dark
changed the title
frontend/src/hooks/useScript.ts
Outdated
| src: string, | ||
| options: ScriptOptions = defaultOptions, | ||
| ) { | ||
| const [status, setStatus] = React.useState<ScriptStatus>(); |
There was a problem hiding this comment.
in order to avoid an extra render, can you actually check the status from the start
useState<ScriptStatus>(() => {
return document.querySelector(`script[src="${src}"]`)?.dataset.status ?? 'loading'l
})
frontend/src/hooks/useScript.ts
Outdated
|
|
||
| if (script) { | ||
| const domStatus = script.dataset.status; | ||
| if (domStatus) { |
There was a problem hiding this comment.
could we end early and not observer if its already 'ready'/errored?
mscolnick
left a comment
mscolnick
left a comment
There was a problem hiding this comment.
nice work, looks great!
|
sorry I missed out the earlier stuff, you're right on the rerenders! Do you think I should add tests? I'm looking into it |
|
@Light2Dark - up to you if you want to add a test. our hook tests have been pretty minimal, but i have found Claude to be pretty good at writing tests for hooks (smaller than this). in short: if its painless and easy, please do, otherwise don't stress over it |
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.9.19-dev5 |
2 participants
📝 Summary
Fixes #2060 . Adding MathJax library in PlotlyPlugin to render LaTeX for Plotly.
🔍 Description of Changes
useScriptat the same time📋 Checklist
📜 Reviewers
WIP