feat: add BrowserConfig to UserConfig #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let user specify which web browser to use
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
akshayka
commented
Oct 27, 2023
mscolnick
reviewed
Oct 28, 2023
and some minor cleanup
akshayka
commented
Oct 28, 2023
| theme: Literal["light", "dark"] | ||
|
|
||
|
|
||
| class ServerConfig(TypedDict, total=False): |
mscolnick
previously approved these changes
Oct 28, 2023
Contributor
mscolnick
left a comment
mscolnick
left a comment
There was a problem hiding this comment.
can you confirm the frontend doesn't lose this configuration when using the Settings UI? I'm not sure if the read-then-write is lossy on a new top level config section
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let user specify which web browser to use.
Implements the feature requested in #265