create_asgi_app: Marimo server mounted to non-root fails to fetch resources

[liquidcarbon]

The first GET request is successful but blank because it's looking for other resources in root path, not relative to where the app is mounted to.

INFO:     10.91.2.13:5046 - "GET /marimo/motest/ HTTP/1.1" 200 OK
INFO:     10.91.2.13:5046 - "GET /motest/assets/gradient-yHQUC_QB.png HTTP/1.1" 404 Not Found
INFO:     10.91.2.13:63123 - "GET /motest/assets/index-DjpjoHHs.css HTTP/1.1" 404 Not Found
INFO:     10.91.2.13:5046 - "GET /motest/assets/Lora-VariableFont_wght-B2ootaw-.ttf HTTP/1.1" 404 Not Found
INFO:     10.91.2.13:33917 - "GET /motest/assets/PTSans-Regular-CxL0S8W7.ttf HTTP/1.1" 404 Not Found
INFO:     10.91.2.13:61461 - "GET /motest/assets/FiraMono-Regular-BTCkDNvf.ttf HTTP/1.1" 404 Not Found
INFO:     10.91.2.13:28336 - "GET /motest/assets/FiraMono-Medium-DU3aDxX5.ttf HTTP/1.1" 404 Not Found
INFO:     10.91.2.13:1418 - "GET /motest/assets/PTSans-Bold-D9fedIX3.ttf HTTP/1.1" 404 Not Found
INFO:     10.91.2.13:63123 - "GET /motest/assets/FiraMono-Bold-CLVRCuM9.ttf HTTP/1.1" 404 Not Found
INFO:     10.91.2.13:5046 - "GET /motest/assets/index-CBgRIhwa.js HTTP/1.1" 404 Not Found
INFO:     10.91.2.13:33917 - "GET /motest/assets/noise-60BoTA8O.png HTTP/1.1" 404 Not Found

[mscolnick]

Thanks for reporting @liquidcarbon - can you share a minimal repro?

[liquidcarbon]

# tmo/app.py
from fastapi import FastAPI
from marimo import create_asgi_app
from pathlib import Path

# Create a marimo asgi app
marimo_file = Path(__file__).parent / "motest.py"
if marimo_file.exists():
    server = create_asgi_app().with_app(path="/motest", root=marimo_file.as_posix())
else:
    exit()

# Create a FastAPI app
app = FastAPI()
app.mount("/marimo", server.build())

# Run the server
if __name__ == "__main__":
    import uvicorn

    uvicorn.run(app, host="0.0.0.0", port=8001)

# tmo/motest.py
import marimo

__generated_with = "0.9.21"
app = marimo.App(width="full")


@app.cell
def __():
    import marimo as mo
    mo.md("hi")
    return (mo,)


if __name__ == "__main__":
    app.run()

.venv/bin/python -m tmo.app
INFO:     Started server process [1507260]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://0.0.0.0:8001 (Press CTRL+C to quit)
INFO:     10.91.2.13:49972 - "GET /marimo/motest/ HTTP/1.1" 200 OK
INFO:     10.91.2.13:49972 - "GET /motest/assets/gradient-yHQUC_QB.png HTTP/1.1" 404 Not Found
INFO:     10.91.2.13:56494 - "GET /motest/assets/Lora-VariableFont_wght-B2ootaw-.ttf HTTP/1.1" 404 Not Found
INFO:     10.91.2.13:43995 - "GET /motest/assets/index-DjpjoHHs.css HTTP/1.1" 404 Not Found
INFO:     10.91.2.13:54290 - "GET /motest/assets/PTSans-Bold-D9fedIX3.ttf HTTP/1.1" 404 Not Found
INFO:     10.91.2.13:14721 - "GET /motest/assets/PTSans-Regular-CxL0S8W7.ttf HTTP/1.1" 404 Not Found
INFO:     10.91.2.13:55026 - "GET /motest/assets/FiraMono-Regular-BTCkDNvf.ttf HTTP/1.1" 404 Not Found
INFO:     10.91.2.13:49972 - "GET /motest/assets/FiraMono-Medium-DU3aDxX5.ttf HTTP/1.1" 404 Not Found
INFO:     10.91.2.13:56494 - "GET /motest/assets/FiraMono-Bold-CLVRCuM9.ttf HTTP/1.1" 404 Not Found
INFO:     10.91.2.13:43995 - "GET /motest/assets/index-CBgRIhwa.js HTTP/1.1" 404 Not Found
INFO:     10.91.2.13:55026 - "GET /motest/assets/noise-60BoTA8O.png HTTP/1.1" 404 Not Found
INFO:     10.91.2.13:55026 - "GET /motest/favicon.ico HTTP/1.1" 404 Not Found

[liquidcarbon]

with app.mount("/marimo/", server.build()) (with trailing slash), going to the app sends you to /motest

INFO:     10.91.2.13:30711 - "GET /motest/ HTTP/1.1" 404 Not Found

[mscolnick]

Got it, as a workaround, can you mount at the root and just change:

-    server = create_asgi_app().with_app(path="/motest", root=marimo_file.as_posix())
+    server = create_asgi_app().with_app(path="/marimo/motest", root=marimo_file.as_posix())

[liquidcarbon]

Yes, I ended up doing that, but had to move what was already on root. This could be hard if you're adding to a large existing application.

[DanCardin]

I can't tell if my issue is exactly the same as OPs or not, but I am currently reverse proxying an app to /marimo, but mounting with marimo at "" e.g.:

def serve():
    server = marimo.create_asgi_app().with_app(path="", root="main.py")

    app = FastAPI()
    ...
    app.mount("/", server.build())

    root_path = os.environ.get("ROOT_PATH", "")
    uvicorn.run(app, root_path=root_path)

Locally, this appears to all work fine, in that uvicorn prints out paths that include the root_path, and the app loads. but the generated asset urls end up being relative links without the root path, like ./assets/index-CBgRIhwa.js, which when reverse proxied end up 404ing.

And setting with_app(path=root_path changes the actually registered routes, which isn't an option given the rest of the system around it, since the reverse proxy is stripping the root path.

[mscolnick]

@DanCardin What happens if you run with .with_app(path="/",?

[DanCardin]

I dont think I see any difference in behavior between .with_app(path="/", and .with_app(path="",. would you expect there to be?

[mscolnick]

It's been a while since i look at those internals, i don't expect there to be, but it could have an effect (relative path vs absolute path)