Skip to content

Cleanup noisy log annotations #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2025
Merged

Cleanup noisy log annotations #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion extension/src/layers/Lsp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ export const LspLive = Layer.scopedDiscard(
}
}),
),
Effect.annotateLogs({ component: "marmio-lsp" }),
),
);

Expand Down
3 changes: 1 addition & 2 deletions extension/src/services/DebugAdapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ export class DebugAdapter extends Effect.Service<DebugAdapter>()(
config.notebookUri = notebook.value.uri.toString();
yield* Effect.logInfo("Configuration resolved").pipe(
Effect.annotateLogs({
component: "debug-adapter",
notebookUri: config.notebookUri,
type: config.type,
request: config.request,
Expand All @@ -123,6 +122,6 @@ export class DebugAdapter extends Effect.Service<DebugAdapter>()(
});

return { debugType };
}).pipe(Effect.annotateLogs("service", "DebugAdapter")),
}),
},
) {}
1 change: 0 additions & 1 deletion extension/src/services/NotebookSerializer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ export class NotebookSerializer extends Effect.Service<NotebookSerializer>()(
const marimo = yield* LanguageClient;
const runPromise = yield* FiberSet.makeRuntimePromise();

yield* Effect.annotateLogsScoped("service", "NotebookSerializer");
yield* Effect.logInfo("Setting up notebook serializer");

yield* code.workspace.registerNotebookSerializer(notebookType, {
Expand Down